Ver Fonte

Reduce list field length in ipbanlist table from 255 to 15 (#4300)

* Update main.sql

* ipban_cleanup no longer uses hardcoded table name

* Create upgrade_20190814.sql
Jittapan Pluemsumran há 5 anos atrás
pai
commit
8431410a5c
3 ficheiros alterados com 4 adições e 2 exclusões
  1. 1 1
      sql-files/main.sql
  2. 2 0
      sql-files/upgrades/upgrade_20190814.sql
  3. 1 1
      src/login/ipban.cpp

+ 1 - 1
sql-files/main.sql

@@ -731,7 +731,7 @@ CREATE TABLE IF NOT EXISTS `inventory` (
 --
 
 CREATE TABLE IF NOT EXISTS `ipbanlist` (
-  `list` varchar(255) NOT NULL default '',
+  `list` varchar(15) NOT NULL default '',
   `btime` datetime NOT NULL,
   `rtime` datetime NOT NULL,
   `reason` varchar(255) NOT NULL default '',

+ 2 - 0
sql-files/upgrades/upgrade_20190814.sql

@@ -0,0 +1,2 @@
+ALTER TABLE `ipbanlist`
+	CHANGE COLUMN `list` `list` VARCHAR(15) NOT NULL DEFAULT '' FIRST;

+ 1 - 1
src/login/ipban.cpp

@@ -100,7 +100,7 @@ TIMER_FUNC(ipban_cleanup){
 	if( !login_config.ipban )
 		return 0;// ipban disabled
 
-	if( SQL_ERROR == Sql_Query(sql_handle, "DELETE FROM `ipbanlist` WHERE `rtime` <= NOW()") )
+	if( SQL_ERROR == Sql_Query(sql_handle, "DELETE FROM `%s` WHERE `rtime` <= NOW()", ipban_table) )
 		Sql_ShowDebug(sql_handle);
 
 	return 0;